JuliaLinearAlgebra / Octavian.jl

Multi-threaded BLAS-like library that provides pure Julia matrix multiplication
https://julialinearalgebra.github.io/Octavian.jl/stable/
Other
231 stars 18 forks source link

Use Polyester to allocate threads. Fixes #105 #106

Closed chriselrod closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #106 (871b1ac) into master (1f9ce87) will decrease coverage by 0.56%. The diff coverage is 88.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
- Coverage   85.59%   85.03%   -0.57%     
==========================================
  Files          11       11              
  Lines         743      755      +12     
==========================================
+ Hits          636      642       +6     
- Misses        107      113       +6     
Impacted Files Coverage Δ
src/global_constants.jl 42.00% <ø> (ø)
src/block_sizes.jl 88.33% <14.28%> (-8.34%) :arrow_down:
src/memory_buffer.jl 70.00% <63.63%> (+1.57%) :arrow_up:
src/init.jl 69.56% <66.66%> (ø)
src/funcptrs.jl 97.01% <96.66%> (-0.05%) :arrow_down:
src/matmul.jl 90.69% <97.67%> (+0.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1f9ce87...871b1ac. Read the comment docs.

chriselrod commented 3 years ago

Failures seem to be a mix of

  1. wrong answers where we can see that the printed results don't match
  2. wrong answers where printed results do match
  3. segfaults

I can't reproduce any of these problems locally.