search

JuliaLinearAlgebra / Octavian.jl

Multi-threaded BLAS-like library that provides pure Julia matrix multiplication
https://julialinearalgebra.github.io/Octavian.jl/stable/
Other
230 stars 18 forks source link

bump compat for ArrayInterface, ThreadingUtilities, and Static #139

Closed ranocha closed 2 years ago

ranocha commented 2 years ago

Closes #136, closes #137, closes #138

The CI tests of the PRs linked above fail since they depend on each other to get the latest versions. This PR combines all three compat updates, so CI should hopefully run without problems (tests pass locally for me).

I also added a test/Project.toml to allow setting compat bounds of test dependencies and let CompatHelper track it.

chriselrod commented 2 years ago

Badly named PR, but: https://github.com/JuliaLinearAlgebra/Octavian.jl/pull/133 I'll have to look into the test failures there, but they're very likely related to CPUSummary 0.1.11 being broken (i.e. hwloc=false) and it giving possibly contradictory information leading to Octavian not allocating enough information.

ThreadingUtilties 0.5 was a breaking release and will require changes to support. See the using ThreadingUtilities: SPIN and the _atomic_store!(p, SPIN)s here: https://github.com/JuliaLinearAlgebra/Octavian.jl/pull/133/files Those are enough for tests to pass locally.

ranocha commented 2 years ago

I see. Thanks for the info! I added the updates for ThreadingUtilities.jl that you mentioned. Feel free to close this PR if it doesn't help, of course.

ranocha commented 2 years ago

Looks like there are several x86 test failures. x64 seems to pass (except Aqua failures checking the formatting of Project.toml, which I can't reproduce locally). I'll close this in favor of #133