JuliaLinearAlgebra / Octavian.jl

Multi-threaded BLAS-like library that provides pure Julia matrix multiplication
https://julialinearalgebra.github.io/Octavian.jl/stable/
Other
226 stars 18 forks source link

CompatHelper: bump compat for "ArrayInterface" to "6" #145

Closed github-actions[bot] closed 2 years ago

github-actions[bot] commented 2 years ago

This pull request changes the compat entry for the ArrayInterface package from 3.1.14, 5.0.1 to 3.1.14, 5.0.1, 6.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

codecov[bot] commented 2 years ago

Codecov Report

Merging #145 (5812fcd) into master (db713f3) will decrease coverage by 1.25%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
- Coverage   88.72%   87.47%   -1.26%     
==========================================
  Files          13       13              
  Lines         878      878              
==========================================
- Hits          779      768      -11     
- Misses         99      110      +11     
Impacted Files Coverage Δ
src/init.jl 64.28% <0.00%> (-14.29%) :arrow_down:
src/global_constants.jl 61.22% <0.00%> (-8.17%) :arrow_down:
src/funcptrs.jl 97.33% <0.00%> (-2.67%) :arrow_down:
src/matmul.jl 92.52% <0.00%> (-0.32%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update db713f3...5812fcd. Read the comment docs.

ranocha commented 2 years ago

Bump. It would be great to get a new release of OCtavian.jl allowing ArrayInterface.jl v6 (see, e.g., https://github.com/SciML/OrdinaryDiffEq.jl/issues/1676).

chriselrod commented 2 years ago

All the test failures were all x86(i.e. 32 bit) with multiple threads. I am tempted to

if sizeof(Int) < 8
  matmul!(args...) = LinearAlgebra.mul!(args...)
else
  # actual library
  include(...)
end
chriselrod commented 2 years ago

https://github.com/JuliaLinearAlgebra/Octavian.jl/pull/146

ranocha commented 2 years ago

What about re-running CI after merging #146?

chriselrod commented 2 years ago

This should have been closed by #146.