search

JuliaLinearAlgebra / Octavian.jl

Multi-threaded BLAS-like library that provides pure Julia matrix multiplication
https://julialinearalgebra.github.io/Octavian.jl/stable/
Other
226 stars 18 forks source link

Add Invalidations.yml #156

Closed ranocha closed 1 year ago

ranocha commented 1 year ago

This is based on https://github.com/julia-actions/julia-invalidations. Adding such checks came up in https://discourse.julialang.org/t/potential-performance-regressions-in-julia-1-8-for-special-un-precompiled-type-dispatches-and-how-to-fix-them/86359. I suggest to add this check here since this package is widely used as a dependency.

See also SciML/MuladdMacro.jl#26 and SciML/MuladdMacro.jl#29

chriselrod commented 1 year ago

I don't have permission to force merging on Octavian. Tests have to pass first.

ranocha commented 1 year ago

I see. I changed the commit message, so CI should run now.

codecov[bot] commented 1 year ago

Codecov Report

Base: 86.11% // Head: 85.81% // Decreases project coverage by -0.30% :warning:

Coverage data is based on head (eebc5a6) compared to base (72dc756). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #156 +/- ## ========================================== - Coverage 86.11% 85.81% -0.31% ========================================== Files 13 13 Lines 994 994 ========================================== - Hits 856 853 -3 - Misses 138 141 +3 ``` | [Impacted Files](https://codecov.io/gh/JuliaLinearAlgebra/Octavian.jl/pull/156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaLinearAlgebra) | Coverage Δ | | |---|---|---| | [src/funcptrs.jl](https://codecov.io/gh/JuliaLinearAlgebra/Octavian.jl/pull/156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaLinearAlgebra#diff-c3JjL2Z1bmNwdHJzLmps) | `97.29% <0.00%> (-2.71%)` | :arrow_down: | | [src/matmul.jl](https://codecov.io/gh/JuliaLinearAlgebra/Octavian.jl/pull/156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaLinearAlgebra#diff-c3JjL21hdG11bC5qbA==) | `91.52% <0.00%> (-0.29%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaLinearAlgebra). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaLinearAlgebra)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.