JuliaLinearAlgebra / Octavian.jl

Multi-threaded BLAS-like library that provides pure Julia matrix multiplication
https://julialinearalgebra.github.io/Octavian.jl/stable/
Other
226 stars 18 forks source link

Cpusummary 0.1.26 #157

Closed chriselrod closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Base: 86.17% // Head: 86.67% // Increases project coverage by +0.50% :tada:

Coverage data is based on head (304f39e) compared to base (76de17c). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #157 +/- ## ========================================== + Coverage 86.17% 86.67% +0.50% ========================================== Files 13 13 Lines 998 998 ========================================== + Hits 860 865 +5 + Misses 138 133 -5 ``` | [Impacted Files](https://codecov.io/gh/JuliaLinearAlgebra/Octavian.jl/pull/157?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaLinearAlgebra) | Coverage Δ | | |---|---|---| | [src/Octavian.jl](https://codecov.io/gh/JuliaLinearAlgebra/Octavian.jl/pull/157/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaLinearAlgebra#diff-c3JjL09jdGF2aWFuLmps) | `50.00% <ø> (ø)` | | | [src/global\_constants.jl](https://codecov.io/gh/JuliaLinearAlgebra/Octavian.jl/pull/157/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaLinearAlgebra#diff-c3JjL2dsb2JhbF9jb25zdGFudHMuamw=) | `12.00% <100.00%> (+6.00%)` | :arrow_up: | | [src/matmul.jl](https://codecov.io/gh/JuliaLinearAlgebra/Octavian.jl/pull/157/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaLinearAlgebra#diff-c3JjL21hdG11bC5qbA==) | `92.37% <0.00%> (+0.56%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaLinearAlgebra). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaLinearAlgebra)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

chriselrod commented 1 year ago

Multithreaded x86 is failing. Note it is failing on master as well: https://github.com/JuliaLinearAlgebra/Octavian.jl/runs/8240502733?check_suite_focus=true

chriselrod commented 1 year ago

Would anyone complain if we just abandon 32 bit support? @DilumAluthge

I'm not inclined to spend any of my free time maintaining it.

Either Octavian will not be compatible with recent versions of dependencies, or we drop 32 bit.

DilumAluthge commented 1 year ago

No complaints from me!