Closed chriselrod closed 1 year ago
Patch coverage has no change and project coverage change: -0.47
:warning:
Comparison is base (
c63b5b9
) 90.40% compared to head (9e0551e
) 89.93%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@ranocha have you seen this?
No - but I have to admit that I haven't been running a lot of matmul!
-based code recently, focused on other parts of our codebase instead.
Thanks a lot for fixing this! Do you have an idea which Julia bugs are involved here?
Thanks a lot for fixing this! Do you have an idea which Julia bugs are involved here?
No, but bugs such as this have been known for a long time. TriangularSolve.jl had to disable precompilation as well for this reason.
Precompilation kills runtime performance because of Julia bugs. Master:
PR:
@ranocha have you seen this?
This was the benchmark script I used: