JuliaLinearAlgebra / Octavian.jl

Multi-threaded BLAS-like library that provides pure Julia matrix multiplication
https://julialinearalgebra.github.io/Octavian.jl/stable/
Other
230 stars 18 forks source link

Bump VB and LV requirements, minor syncmul adjustments #96

Closed chriselrod closed 3 years ago

chriselrod commented 3 years ago

I made a threading adjustment that broke things; was fixed with VectorizationBase 0.20.16. I really should get around to setting up BuildKite to automate integration testing, instead of having to manually run tests on all down stream packages to see if things work.

VectorizationBase isn't a pleasant package to write unit tests for on it's own, since much of the code is less "made for humans" and more "made for LoopVectorization", so it's more natural to test via running @(t)turbo code.

codecov[bot] commented 3 years ago

Codecov Report

Merging #96 (af923dd) into master (0292d3f) will decrease coverage by 4.80%. The diff coverage is 94.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
- Coverage   86.60%   81.79%   -4.81%     
==========================================
  Files          11       11              
  Lines         724      736      +12     
==========================================
- Hits          627      602      -25     
- Misses         97      134      +37     
Impacted Files Coverage Δ
src/matmul.jl 81.27% <92.59%> (-9.10%) :arrow_down:
src/complex_matmul.jl 100.00% <100.00%> (ø)
src/funcptrs.jl 100.00% <100.00%> (ø)
src/macrokernels.jl 89.55% <100.00%> (+1.31%) :arrow_up:
src/utils.jl 67.64% <100.00%> (ø)
src/memory_buffer.jl 36.84% <0.00%> (-31.58%) :arrow_down:
src/global_constants.jl 50.00% <0.00%> (-10.00%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cefc49e...af923dd. Read the comment docs.