search

JuliaLinearAlgebra / Preconditioners.jl

A few preconditioners for iterative solvers.
https://julialinearalgebra.github.io/Preconditioners.jl/
Other
50 stars 11 forks source link

Julia v1.0 fixes #2

Closed mohamed82008 closed 5 years ago

chriscoey commented 5 years ago

bump!

mohamed82008 commented 5 years ago

Ya sorry, forgot about this one! I will give it some time. The main hurdle here was that no one was willing to maintain IncompleteSelectedInversion.jl which is not registered, but I can switch it out now with https://github.com/JuliaSmoothOptimizers/LimitedLDLFactorizations.jl which seems up to date. I will give this some time if not this weekend, then the next one.

mohamed82008 commented 5 years ago

Tests pass on my machine. If Travis says it's ok, I will merge today.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 19

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Preconditioners.jl 1 4 25.0%
src/amg.jl 5 10 50.0%
src/incompletecholesky.jl 17 26 65.38%
<!-- Total: 23 40 57.5% -->
Files with Coverage Reduction New Missed Lines %
src/amg.jl 1 57.14%
src/incompletecholesky.jl 2 63.33%
src/diagonal.jl 4 44.44%
<!-- Total: 7 -->
Totals Coverage Status
Change from base Build 9: -17.3%
Covered Lines: 36
Relevant Lines: 66
💛 - Coveralls
codecov-io commented 5 years ago

Codecov Report

Merging #2 into master will decrease coverage by 17.32%. The diff coverage is 57.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #2       +/-   ##
===========================================
- Coverage   71.87%   54.54%   -17.33%     
===========================================
  Files           3        4        +1     
  Lines          64       66        +2     
===========================================
- Hits           46       36       -10     
- Misses         18       30       +12
Impacted Files Coverage Δ
src/diagonal.jl 44.44% <ø> (-22.23%) :arrow_down:
src/Preconditioners.jl 25% <25%> (ø)
src/amg.jl 57.14% <50%> (-15.08%) :arrow_down:
src/incompletecholesky.jl 63.33% <65.38%> (-11.67%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9ec0dc5...e59bcb0. Read the comment docs.