search

JuliaLinearAlgebra / Preconditioners.jl

A few preconditioners for iterative solvers.
https://julialinearalgebra.github.io/Preconditioners.jl/
Other
50 stars 11 forks source link

Allow kwargs to pass to lldl #32

Closed JeffFessler closed 1 year ago

JeffFessler commented 1 year ago

This should address #30. I have not yet added and tests to confirm the additional functionality. @learning-chip does this seem like the appropriate extension and can you suggest a test?

mohamed82008 commented 1 year ago

The implementation looks correct to me. Please add a test and let's this get this merged.

JeffFessler commented 1 year ago

I added a minimal test. I also made it more clear to future developers which functions come from which packages. There was also an unused where T that julia v1.8 complained about that I removed. And I bumped the version to 0.6.

JeffFessler commented 1 year ago

@mohamed82008 this is ready for you to review