search

JuliaLinearAlgebra / libblastrampoline

Using PLT trampolines to provide a BLAS and LAPACK demuxing library.
MIT License
66 stars 17 forks source link

Cygwin build fix #108

Closed stahta01 closed 1 year ago

stahta01 commented 1 year ago

I am trying to get Julia to build using USE_BINARYBUILDER=0 and I think an endif was in the wrong place.

stahta01 commented 1 year ago

I think an endif was in the wrong place.

Not really: we purposefully do not want extra symlinks on Windows, they're only source of trouble, see #97.

So, you do not support building this package under Windows. Nothing built because of this problem for this package.

Please look at target "all: $(builddir)/libblastrampoline.$(SHLIB_EXT)"

Tim S.

giordano commented 1 year ago

Explaining what is the problem that you're trying to solve would be more constructive than accusing people not to want to make things work.

stahta01 commented 1 year ago

Please explain what target all does! When the below target does not exist.

$(builddir)/libblastrampoline.$(SHLIB_EXT)
giordano commented 1 year ago

Also

So, you do not support building this package under Windows.

is plainly false since CI runs successfully on Windows here. Maybe you have a different setup, and that's OK, but then it's on you to explain why something doesn't work for you and how you're trying to fix it without breaking the rest.

stahta01 commented 1 year ago

The change failed later; but, it still failed on building Julia; The first changed worked; but, it was not correct per you.

stahta01 commented 1 year ago

I changed it to just edit the all target. It now builds on windows under Julia; I consider it not as good as my first commit; but, maybe you will find it acceptable.

stahta01 commented 1 year ago

Turns out testing was not very hard the changes you suggested worked building this project standalone on Windows. And, the output should work when building Julia after I patch julia some more.

Tim S.

stahta01 commented 1 year ago

Explaining what is the problem that you're trying to solve would be more constructive than accusing people not to want to make things work.

I was up for over 24 hours straight I apologize. Tim S.