Closed giordano closed 3 years ago
Well, tests didn't like it :smile:
Thanks! This works here. No idea about the test failures, but I'm surprised that the C code doesn't seem to be built in the logs?
This breaks the tests because test/dgemm_test/Makefile
sources Make.inc
, and this forces LDFLAGS
to include -shared
, which is not what we want.
I originally created CFLAGS_add
for this exact purpose; clients should provide CFLAGS_add
and leave CFLAGS
alone. If that's not standard, we can instead swap the names CFLAGS -> LBT_CFLAGS
and CFLAGS_add -> CFLAGS
.
AFAICT overriding CFLAGS is considered as standard (notably by distributions), so swapping variable names sounds better (and it's what Julia does for example).
Yeah, I think you're right. I think the CFLAGS_add
thing was a habit picked up from an old version of Julia. ;)
Feels like we're using the wrong compiler?
Any news on this?
The x86 Linux job didn't compile with -m32
, which explains the error, but if I log into the machine i get:
julia> include("test/utils.jl")
lbt_get_default_func (generic function with 1 method)
julia> needs_m32()
true
Great.
Edit: ok, the problem was that in the tests we were still using CFLAGS_add
Should be good to go now, tests passing on all platforms.
Thanks! It would be nice to backport this to Julia 1.7 to help other distro packagers.
Fix #44. @nalimilan could you please test this out? I think this is now doing what you want: