tkf commented 4 years ago

Once we have more machinery in @logprogress (as done in #13), it makes sense to use it inside @progress. However, this PR as-is has a hygiene issue when combined with #13. I think this because it does not pick up parent ID correctly as the variable name is doubly mangled. When I have hygiene issue I usually just give up and manually gensym. But is there a better way to do it?

codecov-io commented 4 years ago

Codecov Report

Merging #14 into master will increase coverage by 0.79%. The diff coverage is 56.17%.

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   70.98%   71.77%   +0.79%     
==========================================
  Files           1        1              
  Lines         162      163       +1     
==========================================
+ Hits          115      117       +2     
+ Misses         47       46       -1

Impacted Files	Coverage Δ
src/ProgressLogging.jl	`71.77% <56.17%> (+0.79%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 90cd0c1...2f3f2ea. Read the comment docs.

tkf commented 4 years ago

@pfitzseb Maybe you want to have a look at it, as I guess Juno users are the main users of @progress?

JuliaLogging / ProgressLogging.jl

Use at-withprogress etc. in at-progress #14

Codecov Report