change nan to nothing for fast-math mode

JuliaLogging / ProgressLogging.jl

MIT License

50 stars 8 forks source link

Closed daviehh closed 4 years ago

daviehh commented 4 years ago

Re: https://github.com/c42f/TerminalLoggers.jl/issues/31, in fast-math mode NaN checks is no longer available, thus change indeterminate state to nothing.

tkf commented 4 years ago

Hi, thanks a lot for this and the other PR!

Did you check that https://github.com/c42f/TerminalLoggers.jl/issues/31 works with this and https://github.com/c42f/TerminalLoggers.jl/pull/33? If so, I think this patch is good to go once the test is fixed.

daviehh commented 4 years ago

Yes, checked locally ok. Updated test from NaN to nothing to reflect this change

tkf commented 4 years ago

Thanks a lot!