search

JuliaLogging / ProgressLogging.jl

MIT License
50 stars 8 forks source link

Method ambiguities reported by Aqua #48

Open prbzrg opened 10 months ago

prbzrg commented 10 months ago

In Julia v1.10, I used Aqua to detect method ambiguities in my package https://github.com/impICNF/ContinuousNormalizingFlows.jl/issues/356 and some of its report were related to this package:

Ambiguity #57
convert(::Type{T}, str::ProgressLogging.ProgressString) where T<:AbstractString @ ProgressLogging ~/.julia/packages/ProgressLogging/6KXlp/src/ProgressLogging.jl:211
convert(::Type{Union{SubString{String}, String}}, s::AbstractString) @ Base strings/substring.jl:64

Possible fix, define
  convert(::Type{Union{SubString{String}, String}}, ::ProgressLogging.ProgressString)

Ambiguity #58
convert(::Type{T}, str::ProgressLogging.ProgressString) where T<:AbstractString @ ProgressLogging ~/.julia/packages/ProgressLogging/6KXlp/src/ProgressLogging.jl:211
convert(::Type{SubString{S}}, s::AbstractString) where S<:AbstractString @ Base strings/substring.jl:57

Possible fix, define
  convert(::Type{SubString{S}}, ::ProgressLogging.ProgressString) where S<:AbstractString

I would appreciate your attention to this issue.