search

JuliaLogging / TerminalLoggers.jl

Logging sinks and utilites for interactive terminals
MIT License
41 stars 10 forks source link

Colorize progress bars #12

Closed tkf closed 4 years ago

tkf commented 4 years ago

I suggest using green for active progress bars and gray for completed progress bars. ATM, we don't use any color.

Example (with https://github.com/JuliaCI/BenchmarkTools.jl/pull/153):

Peek 2020-01-25 22-43

codecov-io commented 4 years ago

Codecov Report

Merging #12 into master will decrease coverage by 1.71%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   96.37%   94.66%   -1.72%     
==========================================
  Files           4        4              
  Lines         193      206      +13     
==========================================
+ Hits          186      195       +9     
- Misses          7       11       +4
Impacted Files Coverage Δ
src/TerminalLogger.jl 91.17% <100%> (-3.27%) :arrow_down:
src/ProgressMeter/ProgressMeter.jl 95.65% <0%> (+0.09%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6523ed7...26029d5. Read the comment docs.

c42f commented 4 years ago

Nice, looks great to me :+1: