search

JuliaLogging / TerminalLoggers.jl

Logging sinks and utilites for interactive terminals
MIT License
41 stars 10 forks source link

Handle nested progress bars #13

Closed tkf closed 4 years ago

tkf commented 4 years ago

This is an implementation of nested progress handling specified by RFC https://github.com/JunoLab/ProgressLogging.jl/pull/13.

It's ready for review but I'm submitting it as a draft since it requires ProgressLogging.jl with https://github.com/JunoLab/ProgressLogging.jl/pull/13 to be released.

Peek 2020-01-26 19-04

c42f commented 4 years ago

This certainly looks promising to me :+1:

c42f commented 4 years ago

This looks pretty good to me at a quick browse.

I wondered if there should have a couple of extra tests here covering how the nesting is printed?

tkf commented 4 years ago

OK, I added some tests for nested progress bars. Anything else you want to address here?

tkf commented 4 years ago

Thanks for the review! Do you think it's ready for another release?

c42f commented 4 years ago

Sure, this is useful so if you want to release feel free. The prospect of a release has inspired me to finish the markdown hacking in #23 so we could try getting that in as well.