Closed aviks closed 4 years ago
Merging #24 into master will increase coverage by
2.52%
. The diff coverage is88.88%
.
@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 95.32% 97.84% +2.52%
==========================================
Files 1 1
Lines 107 93 -14
==========================================
- Hits 102 91 -11
+ Misses 5 2 -3
Impacted Files | Coverage Δ | |
---|---|---|
src/LIBLINEAR.jl | 97.84% <88.88%> (+2.52%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1e6f441...f06f0be. Read the comment docs.
Thank you! I will try it later. One thing to notice is that the original source code was slightly modified to take care of the verbosity. Need to check if the verbose option is working
original source code was slightly modified to take care of the verbosity
I've removed the custom print function in libzz
, and replaced it with a @cfunction
call in Julia. So that part is OK. But if there were changes to the liblinear C code, then if you can point me to the changes, I'll try and incorporate that.
For the record, the build script is here: https://github.com/JuliaPackaging/Yggdrasil/blob/master/L/liblinear/build_tarballs.jl
I'll diff it later today. The change was designed for julia if I remember correctly.
Bump
@cossio checking the changes now. It was a busy working Friday
Great, thanks!
Thanks!
This makes the installation of this package much more robust, on multiple platforms.
cc: @innerlee