Add missing fields to `Parameter`

JuliaML / LIBLINEAR.jl

LIBLINEAR bindings for Julia

Other

12 stars 10 forks source link

Add missing fields to `Parameter` #29

Closed barucden closed 7 months ago

barucden commented 7 months ago

We were missing the fields nu and regularize_bias in the Parameter structure.

Fixes #28.

Discovered when working on JuliaML/LIBSVM.jl#98.

ablaom commented 7 months ago

Thanks for working on this @barucden . I'm not sure I have the knowledge to review this (and have not rights) but I noticed there appears to be some overlap with #26 (still open). In particular the two missing parameters are already added there. Is it possible that PR renders this one moot?

barucden commented 7 months ago

True! I did not check the repository before diving into fixing the bug. #26 is definitely more complete, and we should go with that one. Nevertheless, that PR has been open for a few months already, which brings us to #27