search

JuliaML / LIBSVM.jl

LIBSVM bindings for Julia
Other
88 stars 35 forks source link

Avoid abstract types of fields in SupportVectors #70

Closed barucden closed 3 years ago

barucden commented 3 years ago

I noticed that the SupportVectors structure contained two fields of abstract types. This PR fixes it.

EDIT: also fixed one test that threw errors

barucden commented 3 years ago

Not sure if the failed tests are related to the proposed changes. I don't see how.

iblislin commented 3 years ago

Let's re-run the tests.

codecov-commenter commented 3 years ago

Codecov Report

Merging #70 (c997ae0) into master (a2085ea) will increase coverage by 0.76%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   81.09%   81.86%   +0.76%     
==========================================
  Files           4        4              
  Lines         201      215      +14     
==========================================
+ Hits          163      176      +13     
- Misses         38       39       +1
Impacted Files Coverage Δ
src/LIBSVM.jl 90.05% <ø> (+0.68%) :arrow_up:
src/ScikitLearnAPI.jl 40.54% <0.00%> (+2.30%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a2085ea...c997ae0. Read the comment docs.

iblislin commented 3 years ago

Looks good now. Thanks for your contributions. :+1: