barucden commented 3 years ago

LIBSVM provides function svm_check_parameter that validates the parameters given by SVMParameter. This PR calls this function before calling svm_train.

It also removes one unused return value.

codecov-commenter commented 3 years ago

Codecov Report

Merging #72 (a27130a) into master (095c60b) will increase coverage by 2.08%. The diff coverage is 100.00%.

:exclamation: Current head a27130a differs from pull request most recent head 7e6dd05. Consider uploading reports for the commit 7e6dd05 to get more accurate results

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage   81.86%   83.94%   +2.08%     
==========================================
  Files           4        4              
  Lines         215      218       +3     
==========================================
+ Hits          176      183       +7     
+ Misses         39       35       -4

Impacted Files	Coverage Δ
src/LIBSVM.jl	`92.52% <100.00%> (+2.47%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 095c60b...7e6dd05. Read the comment docs.

iblislin commented 3 years ago

Let's put aside the data var issue and revert changes on it first.

barucden commented 3 years ago

@iblis17 Thanks for the review. The changes are implemented now.

JuliaML / LIBSVM.jl

Call `svm_check_parameter` before training #72

Codecov Report