search

JuliaML / LIBSVM.jl

LIBSVM bindings for Julia
Other
88 stars 35 forks source link

Wrap `ccall`s with proper Julia functions #76

Closed barucden closed 3 years ago

barucden commented 3 years ago

Following #75, this PR wraps all calls to the LIBSVM C library with proper Julia functions. That way we get some type safety and it also makes the code cleaner.

codecov-commenter commented 3 years ago

Codecov Report

Merging #76 (9ae9c4e) into master (e4c64c3) will decrease coverage by 1.13%. The diff coverage is 89.28%.

:exclamation: Current head 9ae9c4e differs from pull request most recent head 95ede48. Consider uploading reports for the commit 95ede48 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
- Coverage   84.01%   82.88%   -1.14%     
==========================================
  Files           4        5       +1     
  Lines         219      222       +3     
==========================================
  Hits          184      184              
- Misses         35       38       +3
Impacted Files Coverage Δ
src/libcalls.jl 85.71% <85.71%> (ø)
src/LIBSVM.jl 91.46% <92.85%> (-1.11%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e4c64c3...95ede48. Read the comment docs.

barucden commented 3 years ago

@iblis17 I did what you suggested about the decision values. We now have a basic test to check the decision values too.

I will try to tackle the pointers later, but I think this one is ready for merge.