search

JuliaML / LearnBase.jl

Abstractions for Julia Machine Learning Packages
Other
17 stars 10 forks source link

Distributions dependency #17

Closed Evizero closed 7 years ago

Evizero commented 7 years ago

We need to find a better solution to the params problem in #14 . LearnBase is not the place to have such a heavy dependency. maybe we can move it closer to the package that needs it @tbreloff ?

Evizero commented 7 years ago

Any comments on this?

joshday commented 7 years ago

I apparently wasn't watching LearnBase until yesterday, so I missed this. Maybe StatsBase would be a good home for params if JuliaStats would be open to that.

tbreloff commented 7 years ago

If this is the only reason for the Distributions dep, then yes I think we should try to get a method stub into StatsBase. I want to continue to export it from LearnBase because I want to maintain the generic nature of the method. We only use the JuliaStats def to avoid clashes.

On Tue, Jan 3, 2017 at 9:11 AM Josh Day notifications@github.com wrote:

I apparently wasn't watching LearnBase until yesterday, so I missed this. Maybe StatsBase would be a good home for params if JuliaStats would be open to that.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JuliaML/LearnBase.jl/issues/17#issuecomment-270151043, or mute the thread https://github.com/notifications/unsubscribe-auth/AA492ueuWLKUdtY2HIuPZc7T5ItrUDNHks5rOnMmgaJpZM4LVcAf .

Evizero commented 7 years ago

fixed by #26