Reset to original interface state (attempt 2)

JuliaML / LearnBase.jl

Abstractions for Julia Machine Learning Packages

Other

17 stars 10 forks source link

Reset to original interface state (attempt 2) #55

Closed darsnack closed 2 years ago

darsnack commented 2 years ago

This reverts the recent changes made in v0.5 to the observation interface. We will release v0.6. MLDataPattern.jl/MLLabelUtils.jl will be compatible with v0.4 and v0.6 (effectively negating v0.5).

See https://github.com/JuliaML/MLUtils.jl/issues/2.

darsnack commented 2 years ago

Had to manually revert each commit then cherry pick a few of them. Git reset won't work in this situation.

darsnack commented 2 years ago

I verified locally that the corresponding PRs to https://github.com/JuliaML/MLDataPattern.jl/pull/65 and https://github.com/JuliaML/MLLabelUtils.jl/pull/46 pass with this PR branch. I could force add the Manifest.toml in on those PRs if we want to run the CI.

CarloLucibello commented 2 years ago

merged and tagged new version