search

JuliaML / LossFunctions.jl

Julia package of loss functions for machine learning.
https://juliaml.github.io/LossFunctions.jl/stable
Other
148 stars 34 forks source link

Deprecate MarginLoss + SparseArray in favour of CategoricalArray #134

Closed juliohm closed 4 years ago

juliohm commented 4 years ago

This PR removes a single method with MarginLoss and SparseArrays that is hanging in the codebase as a workaround for categorical representations. The plan is to think more carefully about an API with CategoricalArrays moving forward. This new API should be more explicit about encoding/decoding schemes, possibly avoiding this memory-hungry full one-hot encoding.

codecov-commenter commented 4 years ago

Codecov Report

Merging #134 into master will decrease coverage by 0.16%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
- Coverage   93.75%   93.58%   -0.17%     
==========================================
  Files          11       10       -1     
  Lines         560      546      -14     
==========================================
- Hits          525      511      -14     
  Misses         35       35
Impacted Files Coverage Δ
src/LossFunctions.jl 100.00% <ø> (ø)
src/supervised.jl 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a0a2fa0...a6746ab. Read the comment docs.