search

JuliaML / LossFunctions.jl

Julia package of loss functions for machine learning.
https://juliaml.github.io/LossFunctions.jl/stable
Other
147 stars 33 forks source link

[WIP] : Added L2MarginLoss #60

Closed kumarkrishna closed 7 years ago

kumarkrishna commented 7 years ago

Adding L2MarginLoss to LossFunctions Fixes #44.

Evizero commented 7 years ago

Hi! Thanks for the contribution. I can't merge, though, without the corresponding tests in place. But I can give some pointers at how to go about them

Could you add the new loss here:

And adapt the following tests for the new loss:

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.2%) to 94.387% when pulling 86db07f73ed3537a2a468ad918632000fc2e0c3a on kumarkrishna:l2marginloss into f2362f81ab7e06ccfd8a42d8ee6c5f65da892f75 on JuliaML:master.

Evizero commented 7 years ago

Thanks!

kumarkrishna commented 7 years ago

Hi! I've put the basic tests in place. As for the unicode plots in the doc-string I am looking into UnicodePlots.jl, and we could merge after adding that?

Evizero commented 7 years ago

The little plots are a little custom tailored and not straight forward. I will take care of it and the docs

kumarkrishna commented 7 years ago

Sure! :)