search

JuliaML / MLDataUtils.jl

Utility package for generating, loading, splitting, and processing Machine Learning datasets
http://mldatautilsjl.readthedocs.io/
Other
102 stars 20 forks source link

[WIP] Added Spiral data generation #17

Closed kumarkrishna closed 7 years ago

kumarkrishna commented 7 years ago

Fixes #6 Tests and Documentation in progress. Sample plot screen shot 2016-11-28 at 11 46 25 pm

Evizero commented 7 years ago

Very cool! Any thoughts on license issues that came up while reading the paper? Also make sure to create your PR to the dev branch as a big refactor will soon be merged into master

Evizero commented 7 years ago

Concerning documentation. We move all the noise from the readme to a nice readthedocs (in fact I am writing on it as we speak). You can find the current status here: http://mldatautilsjl.readthedocs.io/en/dev/

kumarkrishna commented 7 years ago

Looking up on references for the source code, I came across this link where the setting and the code-snippet was first proposed. All later works use the mail list thread as reference. I think providing attribution and citing references should be good.

Evizero commented 7 years ago

nice detective work

kumarkrishna commented 7 years ago

I have added some basic tests for the spiral generation. Any further suggestions on that? Otherwise I think we can merge this for now. As for the documentation, I was thinking of adding that for certain other functions as well in separate Pull Request.

Evizero commented 7 years ago

The tests seem to have some error

kumarkrishna commented 7 years ago

I think this is ready for merge now.

Evizero commented 7 years ago

very nice, thanks