Propose some changes to DataFrames.jl API

JuliaML / MLDataUtils.jl

Utility package for generating, loading, splitting, and processing Machine Learning datasets

http://mldatautilsjl.readthedocs.io/

Other

102 stars 20 forks source link

Open bkamins opened 3 years ago

bkamins commented 3 years ago

I will comment on the rationale of the changes inline (as I might not understand all the details of the intended design).

bkamins commented 3 years ago

CI is failing because only is not defined in Julia 1.0 but this can be fixed later after we confirm the design intention.

johnnychen94 commented 3 years ago

Looks okay to me. Since I don't use DF very much, @oxinabox how does this look to you?

oxinabox commented 3 years ago

Seems right to me though I haven't looked at LearnBase in literally years, and doing #46 seems like a better idea, but this is a net improvement.

bkamins commented 3 years ago

Ah - I have not seen #46. Indeed this PR should be closed if someone is working on #46.