JuliaML / MLDatasets.jl

Utility package for accessing common Machine Learning datasets in Julia
https://juliaml.github.io/MLDatasets.jl/stable
MIT License
228 stars 47 forks source link

MovieLens Datasets #147

Closed Dsantra92 closed 2 years ago

Dsantra92 commented 2 years ago
codecov-commenter commented 2 years ago

Codecov Report

Merging #147 (71ee554) into master (63b865f) will increase coverage by 5.32%. The diff coverage is 76.27%.

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
+ Coverage   38.68%   44.01%   +5.32%     
==========================================
  Files          39       40       +1     
  Lines        1755     2029     +274     
==========================================
+ Hits          679      893     +214     
- Misses       1076     1136      +60     
Impacted Files Coverage Δ
src/datasets/graphs/movielens.jl 76.19% <76.19%> (ø)
src/MLDatasets.jl 100.00% <100.00%> (ø)
src/utils.jl 61.22% <0.00%> (+10.20%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 63b865f...71ee554. Read the comment docs.

Dsantra92 commented 2 years ago

Forgot to add the indentation fix change, will be added in later commit.

Dsantra92 commented 2 years ago

There are inconsistencies in data storing format across the 3 variations: 100k,1m and current datasets(20m, 25m etc.). Will address the issue when all of them have working APIs.

CarloLucibello commented 2 years ago

Are all tests passing locally?

Dsantra92 commented 2 years ago

Are all tests passing locally?

Yes