search

JuliaML / MLDatasets.jl

Utility package for accessing common Machine Learning datasets in Julia
https://juliaml.github.io/MLDatasets.jl/stable
MIT License
228 stars 47 forks source link

Patch/fix ci #154

Closed Dsantra92 closed 2 years ago

Dsantra92 commented 2 years ago

Fix CI issues mentioned in #151 #150

Dsantra92 commented 2 years ago

The download and unzip work perfectly fine for all datasets in a non-CI environment. I am not sure what is causing the error here. I will leave a mail to the GroupLens researchers, maybe they can help.

CarloLucibello commented 2 years ago

Let's put all of the movielens tests in the no_ci file for the time being and merge this as quickly as possible since having broken CI is problematic for other PRs

Dsantra92 commented 2 years ago

Let's put all of the movielens tests in the no_ci file for the time being and merge this as quickly as possible since having broken CI is problematic for other PRs

Okay, that seems to be a better option

codecov-commenter commented 2 years ago

Codecov Report

Merging #154 (9092285) into master (28c6840) will decrease coverage by 9.86%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
- Coverage   43.49%   33.62%   -9.87%     
==========================================
  Files          40       40              
  Lines        1982     2028      +46     
==========================================
- Hits          862      682     -180     
- Misses       1120     1346     +226
Impacted Files Coverage Δ
src/datasets/graphs/movielens.jl 0.73% <0.00%> (-75.57%) :arrow_down:
src/utils.jl 51.02% <0.00%> (-10.21%) :arrow_down:
src/abstract_datasets.jl 22.58% <0.00%> (-0.76%) :arrow_down:
src/datasets/vision/cifar10.jl 2.40% <0.00%> (-0.03%) :arrow_down:
src/graph.jl 50.00% <0.00%> (ø)
src/datasets/graphs/planetoid.jl 100.00% <0.00%> (ø)
...rc/datasets/vision/cifar10_reader/CIFAR10Reader.jl 0.00% <0.00%> (ø)
.../datasets/vision/cifar100_reader/CIFAR100Reader.jl 0.00% <0.00%> (ø)
src/datasets/text/udenglish.jl 56.86% <0.00%> (+0.86%) :arrow_up:
src/datasets/graphs/ogbdataset.jl 57.27% <0.00%> (+1.31%) :arrow_up:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 28c6840...9092285. Read the comment docs.