search

JuliaML / MLDatasets.jl

Utility package for accessing common Machine Learning datasets in Julia
https://juliaml.github.io/MLDatasets.jl/stable
MIT License
229 stars 46 forks source link

Support multiple labels for nodes, edges and graphs #196

Closed Dsantra92 closed 1 year ago

Dsantra92 commented 1 year ago

Our TUDataset implementation didn't support a node, edge or graph having multiple labels. A simple change in delimiter allows us to read all the labels correctly. Ideally closes #195

ToDo:

codecov-commenter commented 1 year ago

Codecov Report

Merging #196 (0f014de) into master (b9a6f71) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #196   +/-   ##
=======================================
  Coverage   41.64%   41.64%           
=======================================
  Files          43       43           
  Lines        2226     2226           
=======================================
  Hits          927      927           
  Misses       1299     1299
Impacted Files Coverage Δ
src/datasets/graphs/tudataset.jl 1.36% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

CarloLucibello commented 1 year ago

It's weird to have a label matrix, they should be separate feature vectors, but since we don't have separate names for them I guess it is ok to let the users handle them. A simple test for issue #195 and we can merge.