search

JuliaML / MLDatasets.jl

Utility package for accessing common Machine Learning datasets in Julia
https://juliaml.github.io/MLDatasets.jl/stable
MIT License
229 stars 46 forks source link

Handle missing values in OGB master csv #204

Closed Dsantra92 closed 1 year ago

Dsantra92 commented 1 year ago

There are some missing value in OGB master CSVs. This pr aims to handle missing value for creating metadata.

Fix: #201

codecov-commenter commented 1 year ago

Codecov Report

Merging #204 (1fd0279) into master (dde2a5b) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #204   +/-   ##
=======================================
  Coverage   48.58%   48.58%           
=======================================
  Files          44       44           
  Lines        2260     2260           
=======================================
  Hits         1098     1098           
  Misses       1162     1162
Impacted Files Coverage Δ
src/datasets/graphs/ogbdataset.jl 83.15% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

CarloLucibello commented 1 year ago

can you add the simple test (either ci or no-ci, depends on the size of the dataset) checking that data = OGBDataset("ogbg-ppa") is loaded properly?

Dsantra92 commented 1 year ago

I am not sure if the dataset will fit my computer memory. I will try none the less.

CarloLucibello commented 1 year ago

I will merge and ask for someone to test in #201