Closed Evizero closed 8 years ago
The code changes look good, but I haven't tested. If you're happy to merge, so am I. Go for it.
On Dec 6, 2015, at 4:05 PM, Christof Stocker notifications@github.com wrote:
Don't worry if you are too busy to check this out. I'll merge this in a few days if there are no objections and if I don't identify any issues.
log story short: I changed the losses to use the new interface.
You can view, comment on, or merge this pull request online at:
https://github.com/tbreloff/MLPlots.jl/pull/6
Commit Summary
use _apply_recipe for losses File Changes
M src/LearnBase/loss.jl (54) Patch Links:
https://github.com/tbreloff/MLPlots.jl/pull/6.patch https://github.com/tbreloff/MLPlots.jl/pull/6.diff — Reply to this email directly or view it on GitHub.
Don't worry if you are too busy to check this out. I'll merge this in a few days if there are no objections and if I don't identify any issues.
long story short: I changed the losses to use the new interface.