search

JuliaML / OpenAIGym.jl

OpenAI's Gym binding for Julia
Other
105 stars 19 forks source link

Speed part 2 #12

Closed JobJob closed 5 years ago

JobJob commented 6 years ago

Uses setdata! from https://github.com/JuliaPy/PyCall.jl/pull/487 which just updates the pointer to the data of the env.state PyArray, rather than creating a new PyArray each step.

requires

This is just one extra small commit on top of #11

iblislin commented 5 years ago

could you rebase this?

JobJob commented 5 years ago

Done, now we're just waiting on https://github.com/JuliaPy/PyCall.jl/pull/487 📅

iblislin commented 5 years ago

Okay. After that PR merged, we still need to wait until new release tagged.

baggepinnen commented 5 years ago

Any obstacles left to merging these two PRs?

codecov-io commented 5 years ago

Codecov Report

Merging #12 into master will decrease coverage by 1.88%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   64.15%   62.26%   -1.89%     
==========================================
  Files           1        1              
  Lines          53       53              
==========================================
- Hits           34       33       -1     
- Misses         19       20       +1
Impacted Files Coverage Δ
src/OpenAIGym.jl 62.26% <ø> (-1.89%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f871376...c65d47a. Read the comment docs.