search

JuliaML / OpenAIGym.jl

OpenAI's Gym binding for Julia
Other
105 stars 20 forks source link

update README #18

Closed iblislin closed 5 years ago

codecov-io commented 5 years ago

Codecov Report

Merging #18 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #18   +/-   ##
=======================================
  Coverage   60.41%   60.41%           
=======================================
  Files           1        1           
  Lines          48       48           
=======================================
  Hits           29       29           
  Misses         19       19

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b4db985...aff6617. Read the comment docs.

JobJob commented 5 years ago

This one, I was gonna say - maybe add a section before Installation Pre-requisites, with something like:

a working installation of gym in python PyCall set up correctly

JobJob commented 5 years ago

but I guess I missed the boat ⛵️

iblislin commented 5 years ago

oh, can re-arrange the section about Python gym

JobJob commented 5 years ago

Maybe just add a link to the section on installing the gym:

Pre-requisites: a working gym install that PyCall.jl can find - see install gym below.

iblislin commented 5 years ago

I already opened an PR #19, feel free to commit to that branch.