tejank10 commented 5 years ago

As pointed out by @shreyas-kowshik, OpenAIGym.jl could not be added on Julia v1.0.2+ due to compatibility issues of Julia version with Reinforce v0.1. Hence the changes.

codecov-io commented 5 years ago

Codecov Report

Merging #23 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   63.46%   63.46%           
=======================================
  Files           1        1           
  Lines          52       52           
=======================================
  Hits           33       33           
  Misses         19       19

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3ec3ff3...1a1f0e2. Read the comment docs.

JobJob commented 5 years ago

Thanks @tejank10. I'm wondering if we want >= 0.1, but I'm gonna merge this for now, as is, to fix #24, and let @iblis17 sort it out, since he has been working on Reinforce.jl.

iblislin commented 5 years ago

I think upgrading to Reinforce 0.2 is fine. There is only one breaking change: parametrice Episode iterator.

JuliaML / OpenAIGym.jl

Reinforce v0.2 compatible #23

Codecov Report