search

JuliaML / OpenAIGym.jl

OpenAI's Gym binding for Julia
Other
105 stars 20 forks source link

Updated syntax to remove pycall warnings. #30

Closed mkschleg closed 5 years ago

mkschleg commented 5 years ago

I just wanted to update the syntax to the new PyCall syntax as mentioned #29 and as seen in running all the tests.

All tests pass locally, but we'll see if they do on the CI.

iblislin commented 5 years ago

Could you bump the PyCall version in Project.toml as well?

mkschleg commented 5 years ago

Will do.

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@5216cfd). Click here to learn what that means. The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #30   +/-   ##
=========================================
  Coverage          ?   64.15%           
=========================================
  Files             ?        1           
  Lines             ?       53           
  Branches          ?        0           
=========================================
  Hits              ?       34           
  Misses            ?       19           
  Partials          ?        0
Impacted Files Coverage Δ
src/OpenAIGym.jl 64.15% <57.14%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5216cfd...a7de1c4. Read the comment docs.