search

JuliaML / Reinforce.jl

Abstractions, algorithms, and utilities for reinforcement learning in Julia
Other
201 stars 35 forks source link

Add Project.toml #38

Closed iblislin closed 4 years ago

iblislin commented 5 years ago

UUID is here: https://github.com/JuliaRegistries/General/blob/master/R/Reinforce/Package.toml#L2

uuid = "0376cc21-f8a9-5fcf-8891-fde1415a4fd3"
felixchalumeau commented 4 years ago

Hi ! I have had a problem installing Reinforce as one the dependencies, LearnBase, has evolved recently to version 0.4.*, which does not have LearnBase.params anymore. This create an error in the precompiling at line 170 of Reinforce.jl file as the mutable struct MouseActionSet{T} is trying to use DiscreteSet from LearnBase.params.

I managed to use it by adding Project.toml and Manifest.toml by myself and forcing to get LearnBase 0.2.2 instead but it wasn't very convenient.

Thus, it would be great to have the Project.toml initially and to fix that issue of dependency toward LearnBase.

Should I also create an issue about the dependency ?

Thanks !

iblislin commented 4 years ago

Ah, I will fix this issue.

iblislin commented 4 years ago

@felixchalumeau I created a PR #44, let's upgrade LearnBase.jl

felixchalumeau commented 4 years ago

Great ! Thanks !