search

JuliaML / Reinforce.jl

Abstractions, algorithms, and utilities for reinforcement learning in Julia
Other
201 stars 35 forks source link

Drop v0.7 support and introduce Project.toml #44

Closed iblislin closed 4 years ago

iblislin commented 4 years ago

@felixchalumeau where is the actual changelog of LearnBase.jl ?

felixchalumeau commented 4 years ago

@felixchalumeau where is the actual changelog of LearnBase.jl ?

@iblis17 I don't know

iblislin commented 4 years ago

okay, I tried to upgrade it. Please try this branch out.

felixchalumeau commented 4 years ago

okay, I tried to upgrade it. Please try this branch out.

ok, I just tried the branch, it seems to work much better !

Also, I was wandering if it would be better to add "Plots" in the dependencies, as it is used in examples/moutain_car.jl ?

iblislin commented 4 years ago

Also, I was wandering if it would be better to add "Plots" in the dependencies, as it is used in examples/moutain_car.jl ?

well, I won't add it. We already have "RecipesBase" as a dep for package source. If you want to make example better, I suggest the style like Flux model-zoo: creating a Project.toml for each examples. e.g: https://github.com/FluxML/model-zoo/tree/master/vision/cdcgan_mnist

iblislin commented 4 years ago

I'm going to register this version.

felixchalumeau commented 4 years ago

well, I won't add it. We already have "RecipesBase" as a dep for package source.

Ok, got it !

If you want to make example better, I suggest the style like Flux model-zoo: creating a Project.toml for each examples. e.g: https://github.com/FluxML/model-zoo/tree/master/vision/cdcgan_mnist

Ok ! Just getting use to julia and more precisely Reinforce.jl and Flux.jl at the moment but it will a pleasure to work on this later!

In any case, thanks for the quick reaction to fix this little issue.