search

JuliaML / TableTransforms.jl

Transforms and pipelines with tabular data in Julia
https://juliaml.github.io/TableTransforms.jl/stable
MIT License
103 stars 16 forks source link

Add isindexable and indices to public API #112

Closed juliohm closed 2 years ago

juliohm commented 2 years ago

Some transforms such as Filter, Sample, and Sort are implemented in terms of row indices. This PR introduces two new trait functions to the public API to facilitate extensions downstream.

@eliascarv I didn't test performance regressions. It would be nice to double check, particularly in the case of Filter if we are doing something suboptimal.

codecov-commenter commented 2 years ago

Codecov Report

Merging #112 (1bc74cd) into master (21e79bf) will increase coverage by 0.18%. The diff coverage is 97.82%.

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
+ Coverage   94.03%   94.22%   +0.18%     
==========================================
  Files          26       26              
  Lines         738      762      +24     
==========================================
+ Hits          694      718      +24     
  Misses         44       44
Impacted Files Coverage Δ
src/transforms.jl 96.96% <50.00%> (-1.47%) :arrow_down:
src/transforms/filter.jl 98.36% <100.00%> (+0.28%) :arrow_up:
src/transforms/sample.jl 100.00% <100.00%> (+5.88%) :arrow_up:
src/transforms/sort.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

juliohm commented 2 years ago

Superseded by #117