search

JuliaML / TableTransforms.jl

Transforms and pipelines with tabular data in Julia
https://juliaml.github.io/TableTransforms.jl/stable
MIT License
103 stars 15 forks source link

Coerce fails with string colspec #194

Closed juliohm closed 11 months ago

juliohm commented 11 months ago

Currently we can Coerce(:a => Multiclass), but we can't Coerce("a" => Multiclass).

Jay-sanjay commented 11 months ago

Hello sir, I guess the above issue could be fixed just by adding a similar line like this https://github.com/JuliaML/TableTransforms.jl/blob/47db7ce725b47d2df0f010a4c31d5c5eb6cf454c/src/transforms/coerce.jl#L25 for defining a string , what do you think sir.

Jay-sanjay commented 11 months ago

I can just raise a PR on it

juliohm commented 11 months ago

Thank you @Jay-sanjay for considering a PR.

Please try to follow the convention in other transforms that already use the ColSpec.

Jay-sanjay commented 11 months ago

sir here is the link to the PR https://github.com/JuliaML/TableTransforms.jl/pull/196

eliascarv commented 11 months ago

closed by #196