Fix #11

[mateuszbaran]

This fixes #11 .

There is some problem with deployment of docs that I can't figure out :confused: .

[codecov[bot]]

Codecov Report

Merging #12 (5f06862) into main (324dd64) will increase coverage by 0.38%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   91.59%   91.97%   +0.38%     
==========================================
  Files          13       13              
  Lines         345      349       +4     
==========================================
+ Hits          316      321       +5     
+ Misses         29       28       -1     

Impacted Files	Coverage Δ
src/ManifoldDiff.jl	96.00% <ø> (+4.00%)	:arrow_up:
src/manifolds.jl	65.85% <100.00%> (+3.69%)	:arrow_up:
src/riemannian_diff.jl	96.36% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[mateuszbaran]

I think we need AbstractMetric and EuclideanMetric in ManifoldsBase.jl to be able to define riemannian_gradient without depending on Manifolds.jl. What do you think @kellertuer ?

[kellertuer]

Sounds good to me.

[kellertuer]

We have the complicated setup here with the label to activate docs - it seems.

[mateuszbaran]

Sounds good to me.

OK, I'll make a PR then.

We have the complicated setup here with the label to activate docs - it seems.

I think I forgot to enable pages in settings. I just did it, maybe it will work now.

[kellertuer]

Ah GH-Pages might be another reason, but you could also simplify the documenter action to really always build the docs :)

[mateuszbaran]

I think what we might have been missing is DOCUMENTER_KEY set up.