JuliaManifolds / ManifoldDiff.jl

Differentiation on manifolds
https://juliamanifolds.github.io/ManifoldDiff.jl/
MIT License
10 stars 2 forks source link

Subgradients #24

Closed hajg-ijk closed 1 year ago

hajg-ijk commented 1 year ago

Adds subgradients file and tests. Currently only for the distance function with exponent 1.

codecov[bot] commented 1 year ago

Codecov Report

Merging #24 (743b4a5) into main (6689895) will increase coverage by 2.30%. The diff coverage is 100.00%.

:exclamation: Current head 743b4a5 differs from pull request most recent head b6cacc2. Consider uploading reports for the commit b6cacc2 to get more accurate results

@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   92.63%   94.93%   +2.30%     
==========================================
  Files          20       15       -5     
  Lines         380      296      -84     
==========================================
- Hits          352      281      -71     
+ Misses         28       15      -13     
Impacted Files Coverage Δ
src/ManifoldDiff.jl 96.00% <ø> (-0.78%) :arrow_down:
src/subgradients.jl 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

kellertuer commented 1 year ago

Nice!

Could you add the subgradient naming scheme to the docs/src/index.md list of how functions are named?