search

JuliaManifolds / ManifoldDiff.jl

Differentiation on manifolds
https://juliamanifolds.github.io/ManifoldDiff.jl/
MIT License
10 stars 2 forks source link

Update for ManifoldsBase 0.15 #33

Closed mateuszbaran closed 1 year ago

mateuszbaran commented 1 year ago

See https://github.com/JuliaManifolds/ManifoldsBase.jl/pull/170

mateuszbaran commented 1 year ago

@kellertuer We can't get CI passing here without merging https://github.com/JuliaManifolds/Manifolds.jl/pull/642#issuecomment-1773874412 and tagging it, and we can't get CI passing there without merging and tagging this PR :disappointed: .

kellertuer commented 1 year ago

I do not follow why that is the case, how did we manage to get this deadlock? We should maybe avoid having this then? Are we using both in their tests?

If both work for you locally we could merge and register both.

mateuszbaran commented 1 year ago

Manifolds.jl is a test dependency of ManifoldDiff.jl -- this is the issue. I will re-check tests here, I'm not sure if I tested it on the latest commit of 0.15.

kellertuer commented 1 year ago

or to be more precise, I was hoping, Manifolds.jl works without Diff.

mateuszbaran commented 1 year ago

ManifoldDiff.jl is a hard dependency of Manifolds.jl.

mateuszbaran commented 1 year ago

ManifoldDiff.jl works locally, so I will merge and tag it.