search

JuliaManifolds / ManifoldML.jl

Other
10 stars 1 forks source link

Tangent PCA and kNN #1

Closed mateuszbaran closed 3 years ago

mateuszbaran commented 3 years ago

Julia ecosystem is so modular that these two require very minimal amounts of glue code. That's why I've made these two methods in a more how-to like description rather than actual implementations in the module itself.

codecov[bot] commented 3 years ago

Codecov Report

Merging #1 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #1   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         3    +1     
  Lines           15        21    +6     
=========================================
+ Hits            15        21    +6
Impacted Files Coverage Δ
src/ManifoldML.jl 100.00% <100.00%> (ø)
src/distances.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ec5e1d7...075b349. Read the comment docs.

kellertuer commented 3 years ago

This is quite a nice start; I think one could put those in a framework, when we have one (i.e. in a fit!/ predict scheme); we have to look for a good framework for that before, though. Until then, this is a really good way to provide these examples.