JuliaManifolds / Manifolds.jl

Manifolds.jl provides a library of manifolds aiming for an easy-to-use and fast implementation.
https://juliamanifolds.github.io/Manifolds.jl
MIT License
366 stars 52 forks source link

Improve support for semi-Riemannian manifolds #422

Open mateuszbaran opened 2 years ago

mateuszbaran commented 2 years ago

Semi-Riemannian manifolds require different methods, see https://arxiv.org/abs/1812.07643 .

kellertuer commented 2 years ago

Should we introduce an interims type AbstractRiemannianManifold <: AbstractManifold and a AbstractSemiRiemannianManifold <: AbstractManifold to distinguish between manifolds that are Riemannian and those that are not? Might be too complicated since it depends on the metric and then the MetricManifold-Decorator might actually change that?

mateuszbaran commented 2 years ago

I'd prefer to have a trait instead of an abstract type like AbstractRiemannianManifold but there should definitely be a way to distinguish Riemannian and pseudo-Riemannian manifolds.

kellertuer commented 2 years ago

A trait sounds good, because that means we can “activate” it for different metric manifolds.