search

JuliaManifolds / Manifolds.jl

Manifolds.jl provides a library of manifolds aiming for an easy-to-use and fast implementation.
https://juliamanifolds.github.io/Manifolds.jl
MIT License
368 stars 53 forks source link

Add Exports, Improve GHA Caches. #626

Closed kellertuer closed 1 year ago

kellertuer commented 1 year ago

It could maybe even be included in the next version that is nearly ready on master?

codecov[bot] commented 1 year ago

Codecov Report

Merging #626 (22a7217) into master (88766b2) will increase coverage by 24.74%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master     #626       +/-   ##
===========================================
+ Coverage   74.27%   99.01%   +24.74%     
===========================================
  Files         104      104               
  Lines       10109    10138       +29     
===========================================
+ Hits         7508    10038     +2530     
+ Misses       2601      100     -2501
Impacted Files Coverage Δ
src/Manifolds.jl 86.66% <ø> (ø)
src/manifolds/ProbabilitySimplex.jl 100.00% <100.00%> (ø)

... and 31 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

kellertuer commented 1 year ago

(Sorry had to retriever with the new tags). Sure will merge this once I see the new cache working correctly.

kellertuer commented 1 year ago

It seems Documenter does not resolve some of the new links (complains about some links) – but I could only fix a few for now. Not sure why the rest (even links within the probability simplex page) are not resolved correctly.

Also one extension is not documented I think?

We could do an Extensions Menu with a page per extension? At leat the is what I will convert the extension documentations to in Manopt I think.

mateuszbaran commented 1 year ago

Weird, IIRC docs for probability simplex worked for me locally, though I didn't @ref to the private functions.

Sure, we can add a new submenu for extensions, though I wouldn't like to wait with tagging a new version until that's ready.

kellertuer commented 1 year ago

Sure I did not mean to do that here, and I fixed the references. It were those within the new private functions that referred to other ones within Manifolds. Also the FisherRaoMetric seems to be private? We could maybe export it. Also does not have to be here. I think this is now working and fine :)

mateuszbaran commented 1 year ago

OK, thanks. I think we can export FisherRaoMetric.