JuliaManifolds / Manifolds.jl

Manifolds.jl provides a library of manifolds aiming for an easy-to-use and fast implementation.
https://juliamanifolds.github.io/Manifolds.jl
MIT License
368 stars 53 forks source link

Fix `Rotations(1)` #636

Closed mateuszbaran closed 1 year ago

mateuszbaran commented 1 year ago

Fixes #635 and some related issues.

codecov[bot] commented 1 year ago

Codecov Report

Merging #636 (dd75d8b) into master (d24f6d2) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #636   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files         106      106           
  Lines       10187    10198   +11     
=======================================
+ Hits        10087    10098   +11     
  Misses        100      100           
Impacted Files Coverage Δ
src/manifolds/GeneralUnitaryMatrices.jl 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

mateuszbaran commented 1 year ago

This is a small bugfix, so I'd like to merge it when CI passes.