JuliaManifolds / Manifolds.jl

Manifolds.jl provides a library of manifolds aiming for an easy-to-use and fast implementation.
https://juliamanifolds.github.io/Manifolds.jl
MIT License
368 stars 53 forks source link

`𝔽` argument of `TangentBundle` is ignored #640

Closed mateuszbaran closed 1 year ago

mateuszbaran commented 1 year ago

It shouldn't be in the where clause here:

const TangentBundle{𝔽,M} =
    VectorBundle{𝔽,TangentSpaceType,M} where {𝔽,M<:AbstractManifold{𝔽}}
kellertuer commented 1 year ago

...but M should? For me either both of them should be there or none of them.

mateuszbaran commented 1 year ago

Hm, right, neither should be there.

mateuszbaran commented 1 year ago

Hm, no, this is actually correct. where here doesn't introduce new symbols, only new constraints. I was confused yesterday.