JuliaManifolds / Manifolds.jl

Manifolds.jl provides a library of manifolds aiming for an easy-to-use and fast implementation.
https://juliamanifolds.github.io/Manifolds.jl
MIT License
368 stars 53 forks source link

Add Julia 1.10-beta to CI, remove nightly #648

Closed mateuszbaran closed 10 months ago

mateuszbaran commented 1 year ago

I think currently Julia nightly tests are more confusing than helpful and we should limit testing to alpha/beta builds of Julia.

codecov[bot] commented 1 year ago

Codecov Report

Merging #648 (bd27542) into master (ab49d04) will increase coverage by 0.00%. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #648   +/-   ##
=======================================
  Coverage   99.40%   99.41%           
=======================================
  Files         108      108           
  Lines       10600    10600           
=======================================
+ Hits        10537    10538    +1     
+ Misses         63       62    -1     

see 1 file with indirect coverage changes

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

mateuszbaran commented 1 year ago

Regarding failure, see https://github.com/JuliaLinearAlgebra/LinearMaps.jl/issues/214

kellertuer commented 1 year ago

I agree on the nightly issue, they were broken for some time now and not helpful; so let's not run them; we could still keep beta versions in a nightly-like fashion to not break tests?

mateuszbaran commented 1 year ago

I'm not sure about running alpha/beta builds in a "nightly" CI. Once we merge the PR enabling support for it, ideally things should not break. If things don't work, we would just delay merging that PR and regressions should be very rare.

kellertuer commented 1 year ago

Ok, that is also fine with me, since you might be right, the beta versions should be more stable than Nightly.

mateuszbaran commented 11 months ago

LinearMaps strikes again: https://github.com/JuliaLinearAlgebra/LinearMaps.jl/issues/219 .