search

JuliaManifolds / Manifolds.jl

Manifolds.jl provides a library of manifolds aiming for an easy-to-use and fast implementation.
https://juliamanifolds.github.io/Manifolds.jl
MIT License
368 stars 53 forks source link

up compat BoundaryValDiffEq #657

Closed dehann closed 10 months ago

dehann commented 11 months ago

Hi, I found the following compat issue. Will let PR CI tests run and see if there are any issues.

dehann commented 11 months ago

Not sure why CompatHelper did not catch this. I looked around for related issues or PR but didn't immediately see one.

kellertuer commented 11 months ago

Interesting; it might be that CompatHelper does not check weak dependencies? At least the CI runs do not look like it would consider those; maybe we should check that those are included as well then.

kellertuer commented 11 months ago

Yes, my impression was correct, see https://github.com/JuliaRegistries/CompatHelper.jl/issues/452

codecov[bot] commented 11 months ago

Codecov Report

Merging #657 (ff58e67) into master (106a8f3) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #657   +/-   ##
=======================================
  Coverage   99.22%   99.22%           
=======================================
  Files         106      106           
  Lines       10481    10481           
=======================================
  Hits        10400    10400           
  Misses         81       81

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

mateuszbaran commented 11 months ago

Thanks! Before merging it would be good to check if BoundaryValueDiffEq v5 is actually used on CI.

mateuszbaran commented 11 months ago

Hm, there seems to be a huge problem with BoundaryValueDiffEq v5

mateuszbaran commented 10 months ago

I will close this in favor of #672 .